Skip to content

Conversation

@rmichela
Copy link
Collaborator

This allows a GrpcServerFactory to specify which java annotations it looks for. This change allows consumers to create one GrpcServerHost for network services, and a different host for InProcess services at the same time.

Alternatively, on host can host real services while the other hosts test doubles.

@codecov
Copy link

codecov bot commented Sep 11, 2017

Codecov Report

Merging #31 into master will increase coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
+ Coverage     51.95%   52.45%   +0.49%     
- Complexity      128      131       +3     
============================================
  Files            30       31       +1     
  Lines           689      692       +3     
  Branches         40       40              
============================================
+ Hits            358      363       +5     
+ Misses          315      314       -1     
+ Partials         16       15       -1
Impacted Files Coverage Δ Complexity Δ
...salesforce/grpc/contrib/spring/GrpcServerHost.java 100% <100%> (+4%) 23 <6> (+2) ⬆️
...esforce/grpc/contrib/spring/GrpcServerFactory.java 100% <100%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbfdcdb...b96e0f5. Read the comment docs.

@rmichela rmichela merged commit b876c39 into master Sep 11, 2017
@rmichela rmichela deleted the feature/better-spring branch September 22, 2017 23:48
rmichela pushed a commit that referenced this pull request Dec 18, 2022
…pi-2.0.4

build(deps): bump slf4j-api from 1.7.32 to 2.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants